release-2.1: sql/parser: fix the action for empty rules #30198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
maddyblue
approved these changes
Sep 13, 2018
A yacc-generated parser is a giant switch in a loop and the data structure is a stack implemented as indexes into an array. Each occurrence of `$$.val` is really `thestack[curpos].val`. Unless one nils things out in the rule action the previous value remains. (That's true of all yacc generators that don't provide destructors for values. GNU Bison and Lemon provide destructors, for example, goyacc and old Bison don't) Release note (bug fix): the `WITH` operand of import/export/backup/restore was sometimes processed improperly. This has been corrected. Release note (bug fix): common table expressions with `WITH` in larger queries were sometimes processed improperly. This has been corrected.
knz
force-pushed
the
backport2.1-30197
branch
from
cd85296 to
08ba22a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #30197.
/cc @cockroachdb/release
Fixes #30141.