Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up some raft-related logs and tests #2998

Merged
merged 2 commits into from
Nov 3, 2015
Merged

Clean up some raft-related logs and tests #2998

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b33e65
Remove an obsolete hack from client_replica_gc_test.go.
bdarnell Nov 3, 2015
68228f5
Replace a spammy log.Infof with a V(6) that matches local style.
bdarnell Nov 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions storage/client_replica_gc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ func TestReplicaGCQueueDropReplica(t *testing.T) {
}
return nil
})

// Restart the store to tear down the test cleanly.
mtc.stopStore(1)
mtc.restartStore(1)
}

// TestReplicaGCQueueDropReplicaOnScan verifies that the range GC queue
Expand Down Expand Up @@ -90,8 +86,4 @@ func TestReplicaGCQueueDropReplicaGCOnScan(t *testing.T) {
}
return nil
})

// Restart the store to tear down the test cleanly.
mtc.stopStore(1)
mtc.restartStore(1)
}
4 changes: 3 additions & 1 deletion storage/store.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1476,7 +1476,9 @@ func (s *Store) processRaft() {
if err != nil {
log.Fatal(err)
}
log.Infof("got an event membership change committed event: %s", cmd.Cmd)
if log.V(6) {
log.Infof("store %s: new committed membership change at inded %d", s, e.Index)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/inded/index/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually exactly this line is very helpful in debugging #2593 which just resurfaced. Would you mind leaving it in place for now?

}

default:
continue
Expand Down