Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _vendor to the end of GOPATH instead of the beginning. #297

Merged
merged 1 commit into from
Feb 1, 2015

Conversation

bdarnell
Copy link
Contributor

@bdarnell bdarnell commented Feb 1, 2015

Pass an explicit path to protoc-gen-gogo.

Both of these changes are motivated by compatibility with the emacs go-projectile package and supporting an isolated per-project GOPATH.

@tschottdorf @cockroachdb/developers

Pass an explicit path to protoc-gen-gogo.
@tbg
Copy link
Member

tbg commented Feb 1, 2015

LGTM.
btw, should we also look at vendoring via godep -r and/or become go-gettable (that should work if we just call make for our C++ deps via go generate)?

@bdarnell
Copy link
Contributor Author

bdarnell commented Feb 1, 2015

go get will not call go generate (go generate is designed to generate files which you then check in to source control), so we won't be able to become go-gettable. I first looked at vendoring via submodules (using godep would be similar), but hit a snag in the docker build. We get into trouble because _vendor includes both source and binaries, and we treat _vendor/rocksdb as a special case to speed up the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants