backport-2.1: storage, roachtest, cli: assorted backports #29390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It won't be the first one I'm looking into. Release note: None
This was used in cockroachdb#29252 and I imagine I'll want to use it again whenever we see the consistency checker fail in the future. Release note: None
Accidentally changed this in cockroachdb#29178. Release note: None
Add two more test cases about the exit status of the `monitor` invocation itself. Release note: None
The test was stopping the engine before the stopper, so the compactor was sometimes able to use the engine while it was being closed. Fixes cockroachdb#29302. Release note: None
|
This change is |
petermattis
approved these changes
Aug 30, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Aug 31, 2018
29390: backport-2.1: storage, roachtest, cli: assorted backports r=petermattis a=tschottdorf storage: remove test-only data race The test was stopping the engine before the stopper, so the compactor was sometimes able to use the engine while it was being closed. Fixes #29302. roachtest: improve TestMonitor Add two more test cases about the exit status of the `monitor` invocation itself. roachtest: fix flake in TestMonitor Accidentally changed this in #29178. cli: add hex option to debug keys This was used in #29252 and I imagine I'll want to use it again whenever we see the consistency checker fail in the future. storage: skip TestClosedTimestampCanServe It won't be the first one I'm looking into. Release note: None Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage: remove test-only data race
The test was stopping the engine before the stopper, so the compactor was
sometimes able to use the engine while it was being closed.
Fixes #29302.
roachtest: improve TestMonitor
Add two more test cases about the exit status of the
monitorinvocationitself.
roachtest: fix flake in TestMonitor
Accidentally changed this in #29178.
cli: add hex option to debug keys
This was used in #29252 and I imagine I'll want to use it again whenever we
see the consistency checker fail in the future.
storage: skip TestClosedTimestampCanServe
It won't be the first one I'm looking into.
Release note: None