storage: remove test-only data race #29341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was stopping the engine before the stopper, so the compactor was sometimes able to use the engine while it was being closed. Fixes cockroachdb#29302. Release note: None
|
This change is |
petermattis
approved these changes
Aug 30, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r=petermattis |
|
come to think of it, I should wait for TC first bors r- |
Canceled |
|
bors r=petermattis |
craig bot
pushed a commit
that referenced
this pull request
Aug 30, 2018
29244: sql: correctly handle NULL arrays in generator funcs r=mjibson a=mjibson Change both unnest and _pg_expandarray to return UnknownReturnType if passed NULL as their first argument during type checking. Teach the type checker that if a func returns UnknownReturnType after type checking, then it is because we didn't have enough information to generate a correct type, and so should produce an error immediately. If these funcs are passed a NULL array during execution (after type checking), they should still succeed. Also fix evalAndReplaceSubqueryVisitor to correctly type expressions during subquery replacement which allows the previous change to work both in local and distsql execution. Fixes #29239 Fixes #28561 Release note (bug fix): The functions `unnest` and `_pg_expandarray` now return an error when called with NULL as their first argument. 29341: storage: remove test-only data race r=petermattis a=tschottdorf The test was stopping the engine before the stopper, so the compactor was sometimes able to use the engine while it was being closed. Fixes #29302. Release note: None Co-authored-by: Matt Jibson <[email protected]> Co-authored-by: Tobias Schottdorf <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was stopping the engine before the stopper, so the compactor
was sometimes able to use the engine while it was being closed.
Fixes #29302.
Release note: None