backport-2.1: sql: fix flaky TestLeaseRenewedPeriodically #28965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Aug 30, 2018
I changed GossipUpdateEvent as well which is strictly not needed but there is a chance without it there will continue to be some flakiness. This fix essentially moves the check for release counts further up before lease acquisition. This fixes a race where after lease acquisition the periodic timer would fire, acquire/release some leases. fixes cockroachdb#28771 Release note: None
vivekmenezes
force-pushed
the
backport2.1-28954
branch
from
f04b688 to
e91f931
Compare
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 31, 2018
28965: backport-2.1: sql: fix flaky TestLeaseRenewedPeriodically r=vivekmenezes a=vivekmenezes Backport 1/1 commits from #28954. /cc @cockroachdb/release --- I changed GossipUpdateEvent as well which is strictly not needed but there is a chance without it there will continue to be some flakiness. This fix essentially moves the check for release counts further up before lease acquisition. This fixes a race where after lease acquisition the periodic timer would fire, acquire/release some leases. fixes #28771 Release note: None Co-authored-by: Vivek Menezes <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #28954.
/cc @cockroachdb/release
I changed GossipUpdateEvent as well which is strictly not needed
but there is a chance without it there will continue to be
some flakiness.
This fix essentially moves the check for release counts
further up before lease acquisition. This fixes a race
where after lease acquisition the periodic timer would
fire, acquire/release some leases.
fixes #28771
Release note: None