closedts/transport: avoid race when using stopper.RunWorker #28903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stopper.RunWorker cannot be called in code which can run concurrently with Stopper.Stop. Use Stopper.RunAsyncTask instead. Fix cockroachdb#28755. Release note: None
|
This change is |
tbg
approved these changes
Aug 21, 2018
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r=tschottdorf |
craig bot
pushed a commit
that referenced
this pull request
Aug 21, 2018
27848: sql: quantize the statement counts reported to the reg server r=knz a=knz Fixes #25114. This preserves every count smaller than 10, then for larger values bucket into buckets that are powers of 10. Release note (sql change): CockroachDB now hides more information from the statement statistics reported to Cockroach Labs. 28793: storage: update the tscache appropriately after a merge r=tschottdorf a=benesch @nvanbenschoten I figured this was in your wheelhouse but feel free to defer the review to @tschottdorf! --- When applying a merge, teach the leaseholder of the LHS range to update its timestamp cache for the keyspace previously owned by the RHS range appropriately. Release note: None 28903: closedts/transport: avoid race when using stopper.RunWorker r=tschottdorf a=benesch Stopper.RunWorker cannot be called in code which can run concurrently with Stopper.Stop. Use Stopper.RunAsyncTask instead. Fix #28755. Release note: None Co-authored-by: Raphael 'kena' Poss <[email protected]> Co-authored-by: Nikhil Benesch <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Aug 27, 2018
29125: backport-2.1: closedts/transport: avoid race when using stopper.RunWorker r=tschottdorf a=benesch Backport 1/1 commits from #28903. /cc @cockroachdb/release --- Stopper.RunWorker cannot be called in code which can run concurrently with Stopper.Stop. Use Stopper.RunAsyncTask instead. Fix #28755. Release note: None Co-authored-by: Nikhil Benesch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopper.RunWorker cannot be called in code which can run concurrently
with Stopper.Stop. Use Stopper.RunAsyncTask instead.
Fix #28755.
Release note: None