ui: remove remote_debugging checks #28209
Conversation
couchand
requested review from
bdarnell,
BramGruneir,
tbg,
a-robinson and
a team
|
This change is |
couchand
force-pushed
the
chore/remove-remote-debugging
branch
from
eeeeabb to
21bfd3a
Compare
There was a problem hiding this comment.
What about on insecure clusters? Is user login used for them too?
Reviewed 4 of 4 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
pkg/server/status.go, line 244 at r1 (raw file):
} ctx = propagateGatewayMetadata(ctx)
I believe you can also get rid of all these propagateGatewayMetadata calls, they were only here to support the remote-allowed checks.
Once cockroachdb#28207 lands, all of these endpoints will be protected by login already, so we can skip the check for the setting remote_debugging.mode. Closes: cockroachdb#24992 Release note (admin ui change): The cluster setting remote_debugging.mode no longer controls access to any web ui API endpoints, since they are already protected behind user login.
couchand
force-pushed
the
chore/remove-remote-debugging
branch
from
21bfd3a to
dd300ff
Compare
There was a problem hiding this comment.
What about on insecure clusters?
¯\_(ツ)_/¯ they're insecure anyway? I suppose we could leave this in place for them if we thought it was valuable.
Reviewable status:
pkg/server/status.go, line 244 at r1 (raw file):
Previously, a-robinson (Alex Robinson) wrote…
I believe you can also get rid of all these
propagateGatewayMetadatacalls, they were only here to support the remote-allowed checks.
Ack, done.
There was a problem hiding this comment.
¯_(ツ)_/¯ they're insecure? I suppose we could leave this in place for them if we thought it was valuable.
Will other sensitive information be exposed in the 2.1 webui when running in insecure mode? If not, then I really don't think we should open this up.
If new sensitive info will be exposed, then I assume a conversation has already been had about that and the same logic would apply here, so I'll defer to that conclusion.
Reviewable status:
Once #28207 lands, all of these endpoints will be protected by login already,
so we can skip the check for the setting remote_debugging.mode.
Closes: #24992
Release note (admin ui change): The cluster setting remote_debugging.mode no
longer controls access to any web ui API endpoints, since they are already
protected behind user login.