sql: add create_regfoo builtins #28155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
jordanlewis
force-pushed
the
create-regfoo
branch
from
1605f47 to
5754a4a
Compare
RaduBerinde
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
I don't think these are useful and safe for general use right? We should probably name theminternal_crdb.XXX
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
These builtins permit explicitly creating the various regfoo types (regtype, regproc, regclass, etc) with both an OID and a name. This is required to properly disambiguate the formatting of OID types, without forcing a re-execution of an introspection query to determine the name or oid of the regfoo type given only the oid or name. Release note: None
jordanlewis
force-pushed
the
create-regfoo
branch
from
5754a4a to
6ca19b8
Compare
|
Done. TFTRs |
knz
approved these changes
Aug 1, 2018
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, 4 of 4 files at r2.
Reviewable status:
|
TFTRs! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Aug 1, 2018
28155: sql: add create_regfoo builtins r=jordanlewis a=jordanlewis These builtins permit explicitly creating the various regfoo types (regtype, regproc, regclass, etc) with both an OID and a name. This is required to properly disambiguate the formatting of OID types, without forcing a re-execution of an introspection query to determine the name or oid of the regfoo type given only the oid or name. Release note: None 28166: sql: remove noPeers peerGroupChecker r=yuzefovich a=yuzefovich There is actually no such notion as "no peers." For some reason, I couldn't match behavior of PG on some logic tests while working on #26666, so I thought PG had "no peers" in RANGE mode. I don't know whether I had a bug at some point and fixed it later or this problem was resolved with making all tests produce deterministic results (see #27635). Release note: None 28172: storageccl: don't skip row after deleted row r=dt a=dt We don't need to manually advance the iterator before calling `continue` since the for loop advances it as well, and doing so means the row _following_ a deleted row is also skipped. Fixes #28171. Release note (bug fix): Fix bug that could skip the row following a deleted row during BACKUP. Co-authored-by: Jordan Lewis <[email protected]> Co-authored-by: yuzefovich <[email protected]> Co-authored-by: David Taylor <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These builtins permit explicitly creating the various regfoo types
(regtype, regproc, regclass, etc) with both an OID and a name. This is
required to properly disambiguate the formatting of OID types, without
forcing a re-execution of an introspection query to determine the name
or oid of the regfoo type given only the oid or name.
Release note: None