sql/parser: unreserve VIEW #27204
Merged
sql/parser: unreserve VIEW #27204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VIEW does not need to be a reserved keyword. In fact, it sounds innocuous enough for users to want to use it as a column name. So make it an unreserved keyword. Release note (sql change): CockroachDB now allows clients to use the word `view` as identifier like in PostgreSQL.
|
This change is |
justinj
reviewed
Jul 9, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
Dont worry :) TFYR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jul 9, 2018
27110: opt: add support for reverse scans r=madhavsuresh a=madhavsuresh The optimizer does not generate plans which include reverse scans. This PR adds support logical support for reverse scans. Release note: None 27145: ui: depend on babel-polyfill r=couchand a=benesch babel-polyfill is the standard means of importing the necessary set of polyfills for the configured babel preset. We were previously forced to manually importing the polyfills we needed because the combination of Node 6, JSDom, and babel-polyfill was broken. Since we're no longer using JSDom (see 7e89701), we can use babel-polyfill. Release note: None 27204: sql/parser: unreserve VIEW r=knz a=knz Found while looking at #26993. VIEW does not need to be a reserved keyword. In fact, it sounds innocuous enough for users to want to use it as a column name. So make it an unreserved keyword. Release note (sql change): CockroachDB now allows clients to use the word `view` as identifier like in PostgreSQL. Co-authored-by: madhavsuresh <[email protected]> Co-authored-by: Nikhil Benesch <[email protected]> Co-authored-by: Raphael 'kena' Poss <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while looking at #26993.
VIEW does not need to be a reserved keyword. In fact, it sounds
innocuous enough for users to want to use it as a column name. So make
it an unreserved keyword.
Release note (sql change): CockroachDB now allows clients to use the
word
viewas identifier like in PostgreSQL.