build: cache ui dependencies in CI #2713
Conversation
|
|
||
| CMD ["/bin/bash"] | ||
| EOF | ||
| cp "$(dirname $0)"/../ui/{bower,npm-shrinkwrap,package,tsd}.json "$(dirname $0)"/../ui/Makefile "$(dirname $0)" |
There was a problem hiding this comment.
are we going to frequently update these? Just asking since any change here requires a manual tag change in circle-deps (which isn't nicely automated b/c of likely caching issues).
There was a problem hiding this comment.
I expect these will be updated a few times in the near future at least as I start building out the site.
There was a problem hiding this comment.
ok, then that solution here looks good.
whoops, misread that as "few times a year". Well, we gotta start somehow. It's only if they changed multiple times a week forever that this would be an issue.
|
LGTM |
|
Reworked this so the caching is in circle-ci instead of in the builder image itself. We'll invoke |
tamird
changed the title
|
|
||
| ENV SKIP_BOOTSTRAP=1 | ||
|
|
||
| CMD ["/bin/bash"] |
There was a problem hiding this comment.
You can move this back to builder.sh, right? Doesn't really matter I suppose.
There was a problem hiding this comment.
Yeah, doesn't really matter. Slightly less surprising this way, I think.
|
LGTM. This is much better. |
|
@petermattis PTAL, had to add a commit because node stuff appears to be owned by root which fails on the cache pruning bit in builder.sh |
|
LGTM |
|
Ran this build a second time after getting a green; confirmed the cache was used and the various dependency fetches were no-ops. |
build: cache ui dependencies in CI
Partially reverts cockroachdb#2713 with a comment explaining why it should be the way it was. Attempt to fix the use of `circle-local.sh` in a dev environment but don't get all the way there.
Closes #2705.
More useful now that we have npm, bower, and tsd.