roachpb,storage: remove DeprecatedVerifyChecksum request #26939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Reviewed 9 of 9 files at r1. Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
nvanbenschoten
approved these changes
Jun 25, 2018
|
bors r=nvanbenschoten,tschottdorf |
Merge conflict (retrying...) |
benesch
force-pushed
the
remove-deprecated-checksum
branch
from
a343625 to
21a0991
Compare
DeprecatedVerifyChecksum request was removed prior to September 2016. It is not sent by a CockroachDB 2.0 cluster, so it's safe to remove in 2.1.
benesch
force-pushed
the
remove-deprecated-checksum
branch
from
21a0991 to
0e94a78
Compare
|
bors r=nvanbenschoten,tschottdorf |
craig bot
pushed a commit
that referenced
this pull request
Jun 26, 2018
26939: roachpb,storage: remove DeprecatedVerifyChecksum request r=nvanbenschoten,tschottdorf a=benesch DeprecatedVerifyChecksum request was removed prior to September 2016. It is not sent by a CockroachDB 2.0 cluster, so it's safe to remove in 2.1. --- Someone more familiar with prop-eval KV should double-check that this is actually safe. 26972: sem/tree: remove TestClusterTimestampConversion r=andreimatei a=andreimatei I can't really tell what this test is testing exactly, but what it does is really weird - it creates a TestingEvalCcontext and then it peeks inside it to update the txn proto's timestamp, only to the retrieve that timestamp and assert some serialization on it. This is bizarre, and also changing a txn's proto like that is not going to be a thing any more - I'm making this proto not be exposed any more, and definitely not writable by the world. In fact, it never was intended to be modified by clients. If a test really needs a transaction at a particular timestamp and the test needs to operate at a high level, there's txn.SetFixedTimestamp(). But that requires a txn to actually exist; the mocking done by tree.NewTestingEvalContext() is not sufficient. I'd like to remove this test... Release note: None Co-authored-by: Nikhil Benesch <[email protected]> Co-authored-by: Andrei Matei <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeprecatedVerifyChecksum request was removed prior to September 2016. It
is not sent by a CockroachDB 2.0 cluster, so it's safe to remove in 2.1.
Someone more familiar with prop-eval KV should double-check that this is actually safe.