distsql: change default disk monitor increment to 1MiB #26856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous increment was 64MiB. This was unnecessarily large and provided too high a granularity for stat reporting. Closes #26793 Release note: None
|
This change is |
|
Review status: Comments from Reviewable |
complete! 0 of 0 LGTMs obtained (and 1 stale)
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 20, 2018
26741: kv, client: don't send non-txn requests through the TxnCoordSender anymore r=andreimatei a=andreimatei We were sending them through the TCS because the TCS was in charge of wrapping them in a Txn and retrying if the batch spanned requests (cause batches need to be atomic and you can only get that cross-range in txns). But that's nasty. The TCS is littered with checks about whether a request is transactional or not, and the code to do the wrapped retry did not belong there anyway. This patch moves the wrapping/retry in a new Sender under the client.DB. Now non-txn requests go through that and then straight to the DistSender. Release note: None 26856: distsql: change default disk monitor increment to 1MiB r=asubiotto a=asubiotto The previous increment was 64MiB. This was unnecessarily large and provided too high a granularity for stat reporting. Closes #26793 Release note: None Co-authored-by: Andrei Matei <[email protected]> Co-authored-by: Alfonso Subiotto Marqués <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous increment was 64MiB. This was unnecessarily large and
provided too high a granularity for stat reporting.
Closes #26793
Release note: None