rfc: ALTER COLUMN TYPE TableAction plan #26787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
vivekmenezes
approved these changes
Jun 18, 2018
| Attempting to make a mixed-version cluster operate with and without | ||
| `TableAction`-aware nodes would be exceeding complicated, so for the | ||
| purposes of implementing this RFC, we will maintain the existing code | ||
| path in parallel with the proposed changes. |
There was a problem hiding this comment.
ALTER COLUMN TYPE will be implemented only through the new TableAction code path.
Update the `ALTER COLUMN TYPE` RFC with a proposed plan for migrating state management from `TableDescriptor.Mutations` into a new `TableActions` collection. Release note: None
maddyblue
approved these changes
Jun 18, 2018
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Jun 18, 2018
26787: rfc: ALTER COLUMN TYPE TableAction plan r=bobvawter a=bobvawter FYI: I was doing this as a separate document, but since it's motivated by `ALTER_COLUMN_TYPE`, it seems like it belongs in this doc. The TL;DR is that `TableMutations` is doing two jobs and doesn't have enough specificity to effectively handle multi-step schema changes. Update the `ALTER COLUMN TYPE` RFC with a proposed plan for migrating state management from `TableDescriptor.Mutations` into a new `TableActions` collection. Release note: None 26807: roachtest: fix store dump version r=nvanbenschoten a=nvanbenschoten This store dump version was accidentally broken in #25541. Release note: None Co-authored-by: Bob Vawter <[email protected]> Co-authored-by: Nathan VanBenschoten <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI: I was doing this as a separate document, but since it's motivated by
ALTER_COLUMN_TYPE, it seems like it belongs in this doc. The TL;DR is thatTableMutationsis doing two jobs and doesn't have enough specificity to effectively handle multi-step schema changes.Update the
ALTER COLUMN TYPERFC with a proposed plan for migrating statemanagement from
TableDescriptor.Mutationsinto a newTableActionscollection.
Release note: None