backupccl: support SHOW BACKUP [RANGES|FILES] #26450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last reference to opt_collate_clause was removed in cockroachdb#24958. Normally this causes goyacc to throw a "rule not reduced" error, but for some reason it's not happening until I make some unrelated changes. (Probably a bug in goyacc.) Take the opportunity to clean up the naming scheme, too: opt_collate is used where optional collation is supported, while opt_collate_unimpl is used where optional collation is not supported. Release note: None
|
This change is |
maddyblue
reviewed
Jun 6, 2018
pkg/ccl/backupccl/show.go
Outdated
|
|
||
| fn: func(desc BackupDescriptor, resultsCh chan<- tree.Datums) { | ||
| for _, span := range desc.Spans { | ||
| resultsCh <- tree.Datums{ |
There was a problem hiding this comment.
Since we are redoing this, might as well do it correctly for all of them: plumb a ctx down here and do the send in a select that is also doing a recv on ctx.Done. Or maybe we definitely don't need that? Seems like it wouldn't hurt and isn't hard.
There was a problem hiding this comment.
Given that these things aren't emitted incrementally, I'm going to adjust the shower interface to return a slice of tree.Datums and then do it properly in the hook fn. Fix incoming.
maddyblue
approved these changes
Jun 6, 2018
dt
approved these changes
Jun 6, 2018
This makes debugging a broken backup substantially easier. Release note (enterprise change): Introduce SHOW BACKUP RANGES and SHOW BACKUP FILES, which show details about the ranges and files, respectively, which comprise a backup.
|
bors r=mjibson,dt |
craig bot
pushed a commit
that referenced
this pull request
Jun 6, 2018
26450: backupccl: support SHOW BACKUP [RANGES|FILES] r=mjibson,dt a=benesch This makes debugging a broken backup substantially easier. Release note (enterprise change): Introduce SHOW BACKUP RANGES and SHOW BACKUP FILES, which show details about the ranges and files, respectively, which comprise a backup. Co-authored-by: Nikhil Benesch <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes debugging a broken backup substantially easier.
Release note (enterprise change): Introduce SHOW BACKUP RANGES and SHOW
BACKUP FILES, which show details about the ranges and files,
respectively, which comprise a backup.