kv: skip TestTxnCoordSenderRetries #26442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
nvanbenschoten
approved these changes
Jun 5, 2018
|
bors r+
…On Tue, Jun 5, 2018 at 4:37 PM, Nathan VanBenschoten < ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26442 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXBcYCN05a3Wbey9e5k0RkuwlsEyVyAks5t5uv4gaJpZM4Ubg42>
.
|
Build failed |
TestTxnCoordSenderRetries is flaky, presumably as a consequence of merging cockroachdb#25541. A subtest is sometimes failing because a CommandFilter that it's using is inadvertently injecting a failure into a lingering request from a previous subtest. Don't know why that PR changed any behavior yet, but it seems more likely that this is a test issue than issue warranting a rollback, so skipping while I figure it out. Touches cockroachdb#26434 Release note: None
andreimatei
force-pushed
the
skip-TestTxnCoordSenderRetries
branch
from
595db18 to
51e781d
Compare
|
bors r+ Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
craig bot
pushed a commit
that referenced
this pull request
Jun 5, 2018
26442: kv: skip TestTxnCoordSenderRetries r=andreimatei a=andreimatei TestTxnCoordSenderRetries is flaky, presumably as a consequence of merging #25541. A subtest is sometimes failing because a CommandFilter that it's using is inadvertently injecting a failure into a lingering request from a previous subtest. Don't know why that PR changed any behavior yet, but it seems more likely that this is a test issue than issue warranting a rollback, so skipping while I figure it out. Touches #26434 Release note: None Co-authored-by: Andrei Matei <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestTxnCoordSenderRetries is flaky, presumably as a consequence of
merging #25541.
A subtest is sometimes failing because a CommandFilter that it's using
is inadvertently injecting a failure into a lingering request from a
previous subtest. Don't know why that PR changed any behavior yet, but
it seems more likely that this is a test issue than issue warranting a
rollback, so skipping while I figure it out.
Touches #26434
Release note: None