Reorganized all local keys into two sections/range: by ID & by Key. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This groups all of the range-local data contiguously into two sections, making range traversals require less seeks and more importantly, less maintenance as new range-local data is added going forward. The trickiest part of this was upgrading the C++ code to properly account for encoded keys, since it now has to decode the key and skip the range ID or range Key to determine whether the tuple being compacted is a transaction record or response cache entry.
spencerkimball
force-pushed
the
spencerkimball/local-keyspace
branch
from
62ad7fa to
287f8f7
Compare
|
|
||
| // RaftLogPrefix returns the system-local prefix shared by all entries in a Raft log. | ||
| func RaftLogPrefix(raftID int64) proto.Key { | ||
| return MakeKey(KeyLocalRangeIDPrefix, encoding.EncodeInt(nil, raftID), KeyLocalRaftLogSuffix) |
There was a problem hiding this comment.
Could this just call MakeRangeIDKey(raftID, KeyLocalRaftLogSuffix, nil)?
There was a problem hiding this comment.
Yes, not sure why I did that. Changed.
|
LGTM |
spencerkimball
added a commit
that referenced
this pull request
Jan 16, 2015
Reorganized all local keys into two sections/range: by ID & by Key.
This was referenced Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This groups all of the range-local data contiguously into two sections,
making range traversals require less seeks and more importantly, less
maintenance as new range-local data is added going forward.
The trickiest part of this was upgrading the C++ code to properly
account for encoded keys, since it now has to decode the key and skip
the range ID or range Key to determine whether the tuple being compacted
is a transaction record or response cache entry.