Makefile: fix check-libroach with linux release toolchain #26298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Linux release toolchain uses an ancient version of glibc that requires linking against -lrt. Teach CMake to link test binaries accordingly on Linux. The Linux release toolchain also uses a very recent version of libstdc++ that must be statically linked. Plumb the link flags down into CMake via the LDFLAGS variable. (Previously they were only passed down to links invoked by Go via the -extldflags flag in the LINKFLAGS variable.) Release note: None
|
This change is |
|
LGTM. Thanks for that. |
|
Thanks for the quick review! bors r=mberhault |
craig bot
pushed a commit
that referenced
this pull request
May 31, 2018
26239: CONTRIBUTING.md: avoid recommendation to use 'go get' r=couchand a=benesch Since #25325 landed, 'go get' no longer works. Adjust our contributing guidelines appropriately. Release note: None /cc @rendaw (thanks for the report!) 26290: sql, opt: Add pg error codes, tests for error messages r=rytaft a=rytaft This commit ensures that all errors in the optbuilder have a pg errorcode. In order to keep the optimizer in sync with the heuristic planner, this commit also updates some of the heuristic planner error messages to match the Postgres error messages and include pgcodes. Other errors in the optbuilder which should never be thrown (e.g., in the default case of a switch statement that covers all cases) have been converted into panics. Release note (sql change): Fixed some error messages to more closely match the Postgres error messages, including the corresponding Postgres error codes. 26296: importccl: re-enable TestImportCSVStmt r=mjibson a=mjibson The underlying bug appears to have been fixed in #26259. Release note: None 26298: Makefile: fix check-libroach with linux release toolchain r=mberhault a=benesch The Linux release toolchain uses an ancient version of glibc that requires linking against -lrt. Teach CMake to link test binaries accordingly on Linux. The Linux release toolchain also uses a very recent version of libstdc++ that must be statically linked. Plumb the link flags down into CMake via the LDFLAGS variable. (Previously they were only passed down to links invoked by Go via the -extldflags flag in the LINKFLAGS variable.) Release note: None Co-authored-by: Nikhil Benesch <[email protected]> Co-authored-by: Rebecca Taft <[email protected]> Co-authored-by: Matt Jibson <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Linux release toolchain uses an ancient version of glibc that
requires linking against -lrt. Teach CMake to link test binaries
accordingly on Linux.
The Linux release toolchain also uses a very recent version of libstdc++
that must be statically linked. Plumb the link flags down into CMake via
the LDFLAGS variable. (Previously they were only passed down to links
invoked by Go via the -extldflags flag in the LINKFLAGS variable.)
Release note: None