storage: add a unit test to test RocksDB's error message is expected #26289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
tbg
approved these changes
May 31, 2018
pkg/storage/engine/rocksdb_test.go
Outdated
|
|
||
| // Verify DeleteFile returns os.ErrNotExist if file does not exist. | ||
| if err := db.DeleteFile("/non/existent/file"); !os.IsNotExist(err) { | ||
| t.Fatalf("expected error '%s', actual '%v'", os.ErrNotExist, err) |
There was a problem hiding this comment.
nit: t.Fatalf("expected IsNotExist, but got %v (%T)", err, err)
Add a unit test to test `OpenFile`, `ReadFile`, and `DeleteFile` in RocksDB return `os.ErrNotExist` error when the file or directory is not found. Related to: cockroachdb#26259. Release note: None
|
bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 31, 2018
26289: storage: add a unit test to test RocksDB's error message is expected r=windchan7 a=windchan7 Add a unit test to test `OpenFile`, `ReadFile`, and `DeleteFile` in RocksDB return `os.ErrNotExist` error when the file or directory is not found. Related to: #26259. Release note: None Co-authored-by: Victor Chen <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a unit test to test
OpenFile,ReadFile, andDeleteFilein RocksDBreturn
os.ErrNotExisterror when the file or directory is not found.Related to: #26259.
Release note: None