backport-2.0: storage: avoid querying pusher where transaction record can't exist #26245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change checks whether a txn has a non-nil key before querying it if it's waiting on an extant transaction which owns a conflicting intent. Previously, the code would query the pusher's txn, even if the key was nil, which would just send a spurious `QueryTxn` request to the first range in the keyspace. Release note: None
|
This change is |
|
bors r+
On Wed, May 30, 2018 at 2:23 PM Alex Robinson ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26245 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135HjhBPPmrfgViuDIogn7Wm5iKNsjks5t3uO1gaJpZM4UTrGg>
.
--
…-- Tobias
|
Build failed |
|
Failure was TestJSONBUpgrade, pinged the existing issue.
bors r+
On Wed, May 30, 2018 at 3:19 PM craig[bot] ***@***.***> wrote:
Build failed
- GitHub CI (Cockroach)
<https://teamcity.cockroachdb.com/viewLog.html?buildId=688263&buildTypeId=Cockroach_UnitTests>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#26245 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AE135AhOTmhSXmiGBfJ2L7SxgOLVpRCeks5t3vDagaJpZM4UTrGg>
.
--
…-- Tobias
|
craig bot
pushed a commit
that referenced
this pull request
May 31, 2018
26245: backport-2.0: storage: avoid querying pusher where transaction record can't exist r=tschottdorf a=tschottdorf Backport 1/1 commits from #26238. /cc @cockroachdb/release --- This change checks whether a txn has a non-nil key before querying it if it's waiting on an extant transaction which owns a conflicting intent. Previously, the code would query the pusher's txn, even if the key was nil, which would just send a spurious `QueryTxn` request to the first range in the keyspace. See #26059 Release note: None Co-authored-by: Spencer Kimball <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #26238.
/cc @cockroachdb/release
This change checks whether a txn has a non-nil key before querying it
if it's waiting on an extant transaction which owns a conflicting intent.
Previously, the code would query the pusher's txn, even if the key was
nil, which would just send a spurious
QueryTxnrequest to the firstrange in the keyspace.
See #26059
Release note: None