Reimplement snapshots as a new implementation of Engine interface. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a TODO in the code and helpful to upcoming changes to implement asynchronous scans of ranges for custodial work. Without, more Engine method variants taking snapshot IDs would be necessary. This change is more in keeping with how we do Batch engines and is simpler. Also remove the InternalSnapshotCopy method, which will be replaced by an in-Raft mechanism whereby the leader feeds the snapshot directly to a requesting follower.
| @@ -835,113 +816,6 @@ func TestRangeIdempotence(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| // TestRangeSnapshot. | |||
| func TestRangeSnapshot(t *testing.T) { | |||
There was a problem hiding this comment.
I would think you'd want some tests that the various snapshot methods do what you expect. Am I just missing where this testing is being done?
There was a problem hiding this comment.
OK, added unittests for all snapshot methods.
Changed NewSnapshot behavior to log an error and return nil if called from a snapshot.
spencerkimball
added a commit
that referenced
this pull request
Jan 15, 2015
Reimplement snapshots as a new implementation of Engine interface.
| // read-only rocksDBSnapshot engine. | ||
| func (r *RocksDB) NewSnapshot() Engine { | ||
| if r.rdb == nil { | ||
| log.Errorf("RocksDB is not initialized yet") |
There was a problem hiding this comment.
In general I think it's better to panic than to log an error and return nil (when we cannot return an error) (here and inMemSnapshot.New{Batch,Snapshot})
There was a problem hiding this comment.
Addressed in #257
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a TODO in the code and helpful to upcoming changes to
implement asynchronous scans of ranges for custodial work. Without,
more Engine method variants taking snapshot IDs would be necessary.
This change is more in keeping with how we do Batch engines and is
simpler.
Also remove the InternalSnapshotCopy method, which will be replaced
by an in-Raft mechanism whereby the leader feeds the snapshot directly
to a requesting follower.