Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick-2.0: sql: clarify the error message upon access to vtable with no db #24809

Merged
merged 1 commit into from
Apr 17, 2018

Conversation

knz
Copy link
Contributor

@knz knz commented Apr 15, 2018

Picks #24772.

cc @cockroachdb/release

@knz knz requested review from jordanlewis and a team April 15, 2018 16:56
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz requested a review from justinj April 16, 2018 15:11
Prior to this patch:

```
root@:26257/> select * from pg_catalog.pg_class;
pq: no database specified
```

After:

```
root@:26257/> select * from pg_catalog.pg_class;
pq: cannot access virtual schema in anonymous database
HINT: verify that the current database is set
```

Release note (sql change): the error message produced upon accessing a
virtual schema with no database prefix (e.g. when `database` is not
set) is now clarified.
@knz knz force-pushed the 20180415-cherrypick-24772 branch from 06b5dbf to 0e69155 Compare April 16, 2018 21:35
@knz
Copy link
Contributor Author

knz commented Apr 16, 2018

rebased to resolve conflict, rfal

@knz
Copy link
Contributor Author

knz commented Apr 17, 2018

Thanks!

@knz
Copy link
Contributor Author

knz commented Apr 17, 2018

bors r+

craig bot pushed a commit that referenced this pull request Apr 17, 2018
24809: cherrypick-2.0: sql: clarify the error message upon access to vtable with no db r=knz a=knz

Picks #24772.

cc @cockroachdb/release 

Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig
Copy link
Contributor

craig bot commented Apr 17, 2018

Build succeeded

@craig craig bot merged commit 0e69155 into cockroachdb:release-2.0 Apr 17, 2018
@knz knz deleted the 20180415-cherrypick-24772 branch April 17, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants