doc: fix some typos and update outdated description #24807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dchenk
reviewed
Apr 16, 2018
docs/tech-notes/sql.md
Outdated
| @@ -64,7 +64,7 @@ For example, if the architecture calls out a thing called e.g. "query | |||
| runner", which takes as input a logical query plan (a data structure) | |||
| and outputs result rows (another data structure), you'd usually expect | |||
| a thing in the source code called "query runner" that looks like a | |||
| class whose instances would carry the execution's internal state, a | |||
| class whose instances would carry the execution's internal state, | |||
| providing some methods that take a logical plan as input, and returning | |||
There was a problem hiding this comment.
I'd take the comma out after "input"—it's unnecessary grammatically.
There was a problem hiding this comment.
Yes, you are right. Fixed in a new commit.
Release note: None
|
Looks good, thanks! bors r+ |
Build failed |
|
Hmm, let's try that again bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 17, 2018
24807: doc: fix some typos and update outdated description r=justinj a=yaojingguo fix some typos and update outdated description. Release note: None 24826: engine: clean up EncodeKey function r=petermattis a=yaojingguo 1. Remove duplicated declaration of EncodeKey in db.h. 2. Correct the wrong description of EncodeKey. 3. Remove the unnecessary 1 byte reserved space for string s. Release note: None 24863: doc: fix broken link to Raft SSTable Sideloading RFC r=knz a=yaojingguo Release note: None 24865: opt: fix and reenable stats test r=RaduBerinde a=RaduBerinde The stats test was flaky because we were depending on the asynchronous stat cache invalidation to happen by the time we expect to see the statistic. Fixing by using a different table. Fixes #24773. Release note: None Co-authored-by: Jingguo Yao <[email protected]> Co-authored-by: Radu Berinde <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some typos and update outdated description.
Release note: None