cherry-pick 2.0: distsqlrun: generate TxnCoordMeta in processors that weren't doing it #24609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every processor that uses the flow's txn needs to send metadata about its reads to the root client.Txn/TxnCoordSender. The most critical thing in that metadata is the read spans. Only the TableReader was doing it, but more processors need to. Fixes cockroachdb#24385 Release note: None
|
This change is |
bdarnell
approved these changes
Apr 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #24414
Every processor that uses the flow's txn needs to send metadata about
its reads to the root client.Txn/TxnCoordSender. The most critical thing
in that metadata is the read spans. Only the TableReader was doing it,
but more processors need to.
Fixes #24385
Release note: Fix a possible problem with transactions performing joins doing inconsistent reads.
cc @cockroachdb/release