sql: unreserve the STORED keyword #24554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Apr 6, 2018
knz
approved these changes
Apr 6, 2018
|
Are we sure LATERAL doesn't need to be a reserved word? It isn't even used by the grammar right now, but it will be when we support LATERAL JOINS (possibly happening in 2.1). Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
Yeah, |
Release note (sql change): the word `stored` can again be used to name databases, tables or columns without requiring clients to quote the identifier.
knz
changed the title
|
amended to only unreserve STORED. bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Apr 17, 2018
24554: sql: unreserve the STORED keyword r=knz a=jordanlewis Release note (sql change): the word `stored` can again be used to name databases, tables or columns without requiring clients to quote the identifier. Co-authored-by: Jordan Lewis <[email protected]>
Build succeeded |
craig bot
pushed a commit
that referenced
this pull request
Apr 17, 2018
24864: cherry-pick 2.0: sql: unreserve the STORED keyword r=knz a=knz Picks #24554. cc @cockroachdb/release Co-authored-by: Jordan Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release note (sql change): the word
storedcan again be used to namedatabases, tables or columns without requiring clients to quote the
identifier.