Add important timestamp/date builtins. #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekmenezes
force-pushed
the
vivek/set
branch
from
b498230 to
115bdc8
Compare
| returnType: DummyFloat, | ||
| fn: func(args DTuple) (Datum, error) { | ||
| t := args[1].(DTimestamp) | ||
| s := strings.ToLower(string(args[0].(DString))) |
There was a problem hiding this comment.
nit: t and s are not very descriptive variable names
vivekmenezes
force-pushed
the
vivek/set
branch
from
115bdc8 to
915f095
Compare
| true | ||
|
|
||
| query T | ||
| SELECT now() - current_timestamp < interval '1s' |
There was a problem hiding this comment.
It looks like some of these work with or without parens, while others require parens. We should have a test that current_timestamp() works and now doesn't.
vivekmenezes
force-pushed
the
vivek/set
branch
from
915f095 to
e2f78de
Compare
| @@ -110,6 +110,8 @@ var keywords = map[string]int{ | |||
| "DATABASES": DATABASES, | |||
| "DATE": DATE, | |||
| "DAY": DAY, | |||
| "DAYOFWEEK": DAYOFWEEK, | |||
| "DAYOFYEAR": DAYOFYEAR, | |||
There was a problem hiding this comment.
FYI, I'm pretty sure you don't have to add all of these here and you don't have to add them to sql.ly either. The extract_arg rule accepts IDENT which will capture all of these strings.
vivekmenezes
force-pushed
the
vivek/set
branch
from
e2f78de to
1f2996c
Compare
|
related issue #2427 |
vivekmenezes
force-pushed
the
vivek/set
branch
from
1f2996c to
e562b60
Compare
|
LGTM |
| @@ -470,3 +566,12 @@ func datumToRawString(datum Datum) (string, error) { | |||
|
|
|||
| return "", fmt.Errorf("argument type unsupported: %s", datum.Type()) | |||
| } | |||
|
|
|||
| var nowImpl = builtin{ | |||
There was a problem hiding this comment.
can you put this near the other var? weird to have it here.
|
LGTM |
vivekmenezes
force-pushed
the
vivek/set
branch
from
e562b60 to
9550072
Compare
vivekmenezes
force-pushed
the
vivek/set
branch
from
9550072 to
e23aad9
Compare
vivekmenezes
force-pushed
the
vivek/set
branch
from
e23aad9 to
42447d2
Compare
vivekmenezes
added a commit
that referenced
this pull request
Sep 9, 2015
Add important timestamp/date builtins.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2329