cli: Don't fail zone ls on zones from deleted tables/partitions
#24178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This continues displaying them in the output of `SHOW EXPERIMENTAL ZONE CONFIGURATIONS`, but it still makes some sense there given that the zone configs are still in use, they just aren't addressable. Fixes cockroachdb#24154 Release note (bug fix): Fix a crash in `cockroach zone ls` that would happen if a table with a zone config on it had been deleted but not yet garbage collected. (this was broken in v2.0 alphas, not in v1.1)
|
This change is |
benesch
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This continues displaying them in the output of
SHOW EXPERIMENTAL ZONE CONFIGURATIONS, but it still makes some sense there given that the zoneconfigs are still in use, they just aren't addressable.
Fixes #24154
Release note (bug fix): Fix a crash in
cockroach zone lsthat wouldhappen if a table with a zone config on it had been deleted but not yet
garbage collected. (this was broken in v2.0 alphas, not in v1.1)
This should be cherry-picked to v2.0 because it fixes a broken command with approximately zero risk.