workload: fixture create can make table subset #23433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks pending. pkg/workload/workload.go, line 154 at r1 (raw file):
sorry for the nit, but can we keep this in cmd/workload instead? or at least another file in this package, i'm trying to keep this file from bloating too much Comments from Reviewable |
The new --only-tables flag allows specifying a subset of the tables in a workload for creation. This is useful for benchmarking the workload program itself, as well as creating partial backups of very large datasets. Release note: None
|
Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion. pkg/workload/workload.go, line 154 at r1 (raw file): Previously, danhhz (Daniel Harrison) wrote…
No problem. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new --only-tables flag allows specifying a subset of the tables in a
workload for creation. This is useful for benchmarking the workload
program itself, as well as creating partial backups of very large
datasets.
Release note: None