internal/client: Remove TestCommonMethods #21484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was an attempt at ensuring that we kept the method sets of DB, Batch, and Txn consistent. This was mainly valuable when we intended to expose this package for public consumption. Now that this package is internal-only, it's less important to keep the interfaces perfectly consistent and the ever-growing list of exceptions is just a nuisance. Release note: None
|
This change is |
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was an attempt at ensuring that we kept the method sets of
DB, Batch, and Txn consistent. This was mainly valuable when we
intended to expose this package for public consumption. Now that this
package is internal-only, it's less important to keep the interfaces
perfectly consistent and the ever-growing list of exceptions is just a
nuisance.
Release note: None