storage: Fix simulation of rebalance removals to actually remove targets #20709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
The test, if you're curious: a-robinson@bab317f |
|
@a-robinson LGTM. Sorry for the incomplete fix in #18364 caused some problems for you. #18364 just fix the problem that we could try to rebalance to a target store and then we will remove it immediately, but it couldn't fix the problem that we try to rebalance to a target store with Locality |
|
Fair point that the new test is asking for a little too much. I've made it more lenient and added it to this PR. I'll follow up with the stricter version of the test separately. |
a-robinson
force-pushed
the
allocatorfixes
branch
from
f3b5c62 to
fbe5f7d
Compare
If the first target attempted was rejected due to the simulation claiming that it would be immediately removed, we would reuse the modified `rangeInfo.Desc.Replicas` that had the target added to it, messing with future iterations of the loop. Also, we weren't properly modifying the `candidates` slice, meaning that we could end up trying the same replica multiple times. Release note (bug fix): Improve data rebalancing to make thrashing back and forth between nodes much less likely.
a-robinson
force-pushed
the
allocatorfixes
branch
from
fbe5f7d to
49dd0da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the first target attempted was rejected due to the simulation
claiming that it would be immediately removed, we would reuse the
modified
rangeInfo.Desc.Replicasthat had the target added to it,messing with future iterations of the loop.
Also, we weren't properly modifying the
candidatesslice, meaning thatwe could end up trying the same replica multiple times.
Release note (bug fix): Improve data rebalancing to make thrashing
back and forth between nodes much less likely.