Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/logictest: don't keep processing the test file after a fatal subtest #20656

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

BramGruneir
Copy link
Member

With the new subtest functionality, if an error occurs, it will keep processing the file when a subtest fails. This fixes that.

Release note: None

With the new subtest functionality, if an error occurs, it will keep processing the file when a subtest fails. This fixes that.

Release note: None
@BramGruneir BramGruneir added this to the 1.2 milestone Dec 12, 2017
@BramGruneir BramGruneir requested review from justinj and a team December 12, 2017 19:27
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@justinj justinj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@BramGruneir BramGruneir merged commit f2a7793 into cockroachdb:master Dec 12, 2017
@BramGruneir BramGruneir deleted the logictest2 branch December 12, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants