[WIP] distsql: retry on communication errors #19919
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #19882 This is a stop-gap solution to retry on certain errors seen when a node that participates in a distsql query goes down or is shutdown to not have the onus be on the client to retry, especially since these errors are not returned as retriable errors. There is more work to be done here, tracked in #15637.
|
This change is |
|
To be cherry-picked into 1.1 as customers are having issues with this |
|
Closing PR. Will have another PR that solves a sub-problem of this (when nodes that are part of a distSQL query drain gracefully) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #19882
This is a stop-gap solution to retry on certain errors seen when a node that
participates in a distsql query goes down or is shutdown to not have the
onus be on the client to retry, especially since these errors are not
returned as retriable errors. There is more work to be done here,
tracked in #15637.