Update raft submodule and start using the new raft.Storage interface. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,6 +73,16 @@ type LogEntryState struct { | |||
| Error error | |||
| } | |||
|
|
|||
| // WriteableGroupStorage represents a single group within a Storage. | |||
| // It is implemented by *raft.MemoryStorage. | |||
There was a problem hiding this comment.
Why not move the second sentence of this comment down to line 78 and change it to something like:
// Verify raft.MemoryStorage implements WriteableGroupStorage.
There was a problem hiding this comment.
It's here in the public docstring in part to document why the interface is the way it is, since we're making an interface out of methods defined in another package.
|
LGTM |
bdarnell
force-pushed
the
multiraft-storage
branch
from
aa9ae3c to
67c4f4e
Compare
bdarnell
added a commit
that referenced
this pull request
Dec 2, 2014
Update raft submodule and start using the new raft.Storage interface.
pav-kv
pushed a commit
to pav-kv/cockroach
that referenced
this pull request
Apr 10, 2024
…h-assert-tracker Test: Replace t.error/fatal with assert/request in [/tracker/inflights_test.go]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the raft changes in etcd-io/etcd#7777.
@spencerkimball @cockroachdb/developers