storage/engine: reduce allocations in RocksDBBatchReader #18914
Merged
+43
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than use a bytes.Reader for reading the batch repr, read from a
[]byte. This allows us to return safe slices from
RocksDBBatchReader.{Key,Value} and removes the need to temporarily copy
the key and value.
|
This change is |
|
Reviewed 3 of 3 files at r1. Comments from Reviewable |
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than use a bytes.Reader for reading the batch repr, read from a
[]byte. This allows us to return safe slices from
RocksDBBatchReader.{Key,Value} and removes the need to temporarily copy
the key and value.