storage: do not gather up too many intents/keys #18643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fallout from cockroachdb#18199 and corresponding testing in cockroachdb#15997. I think it'll be nontrivial to max out these budgets in practice, but I can definitely do it in intentionally evil tests, and it's good to know that there is some rudimentary form of memory accounting in this queue.
|
This change is |
| // | ||
| // TODO(tschottdorf): we already send multiple GCRequests if we have too many keys, | ||
| // but we should be dispatching them as we scan to avoid holding the whole chunk of | ||
| // keys in memory. Large Ranges should be the exception, but they can definitely be |
| @@ -751,6 +751,13 @@ func RunGC( | |||
| txnMap := map[uuid.UUID]*roachpb.Transaction{} | |||
| intentSpanMap := map[uuid.UUID][]roachpb.Span{} | |||
|
|
|||
| const ( | |||
| intentBudgetBytes = 30 * 1 << 20 // 30mb | |||
There was a problem hiding this comment.
intentBytesBudget and keyBytesBudget sound better to me. Take it or leave it.
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if intentBytes > intentBudgetBytes { |
There was a problem hiding this comment.
Will this... work? We haven't called processKeysAndValues yet.
There was a problem hiding this comment.
Yeah, I think this needs a test.
| // extremely likely to be collectable unless the user is running | ||
| // very large numbers of very long transactions). But the same | ||
| // consideration as the TODO below holds: we should be handling | ||
| // the chunk and resetting the budget. |
There was a problem hiding this comment.
s/handling the chunks/handling the chunks as we scan
|
Obviated by @spencerkimball's improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallout from #18199 and corresponding testing in #15997. I think it'll be nontrivial to max out
these budgets in practice, but I can definitely do it in intentionally evil tests, and it's good to
know that there is some rudimentary form of memory accounting in this queue.