storage: Add test that the first timeseries range uses epoch leases #18247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A screenshot in cockroachdb#17524 (comment) made me think we might have an off-by-one error here (because it showed the range starting with NodeLivenessKeyMax using an expiration-based lease), but it was a false alarm caused by a bug in the range debug page (cockroachdb#17843). In any case, it's good to test here.
|
This change is |
tbg
approved these changes
Sep 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A screenshot in
#17524 (comment)
made me think we might have an off-by-one error here (because it
showed the range starting with NodeLivenessKeyMax using an
expiration-based lease), but it was a false alarm caused by a bug in
the range debug page (#17843). In any case, it's good to test here.