storage: add timeout to NodeLiveness heartbeat loop #18005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, all commit checks successful. Comments from Reviewable |
|
LGTM. I think the fact that this hit us so hard in our debugging session which motivated this was since there was more going wrong elsewhere. @nvanbenschoten, do you remember the details? |
nvanbenschoten
force-pushed
the
nvanbenschoten/nodeLivenessTimeout
branch
from
fd4b5e5 to
bed3634
Compare
While investigating cockroachdb#17524, we found that a NodeLiveness request was stuck, which blocked the NodeLiveness semaphore. This prevented any liveness updates from being sent by the source of the stuck liveness update. While introducing a timeout here on the liveness loop won't fix the issue we saw, it should prevent stuck liveness updates in the future from preventing a node from ever updating its liveness record, which makes everything harder to deal with.
nvanbenschoten
force-pushed
the
nvanbenschoten/nodeLivenessTimeout
branch
from
bed3634 to
97247c4
Compare
|
Yeah, there was definitely more going wrong so this alone "bringing down the entire liveness range" is probably an inaccurate hyperbole. This in concert with something else was having that effect. I changed the wording to be more specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating #17524, we found that a NodeLiveness request was stuck, which
blocked the NodeLiveness semaphore. This prevented any liveness updates from
being sent by the source of the stuck liveness update. While introducing a
timeout here on the liveness loop won't fix the issue we saw, it should prevent
stuck liveness updates in the future from preventing a node from ever updating
its liveness record, which makes everything harder to deal with.