Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acceptance: disable test_sql_mem_monitor #17793

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

jordanlewis
Copy link
Member

It's causing broken agents due to the large join that causes DistSQL to
spill to disk, which creates files as root because of Docker. Disable
for the time being.

cc @BramGruneir @a-robinson

It's causing broken agents due to the large join that causes DistSQL to
spill to disk, which creates files as root because of Docker. Disable
for the time being.
@jordanlewis jordanlewis requested review from knz and benesch August 21, 2017 22:40
@jordanlewis jordanlewis requested a review from a team as a code owner August 21, 2017 22:40
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@BramGruneir
Copy link
Member

:lgtm:


Reviewed 1 of 3 files at r1.
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


pkg/acceptance/cli_test.go, line 64 at r1 (raw file):

		testFile := filepath.Base(p)
		testPath := filepath.Join(containerPath, testFile)
		if strings.Contains(testPath, "disabled") {

how about hassuffix instead of contains?


Comments from Reviewable

@tbg
Copy link
Member

tbg commented Aug 22, 2017

Can we merge this ASAP please? I think most the agents are bricked.

@tbg
Copy link
Member

tbg commented Aug 22, 2017

God-merge ahoy. Only one previously flaky race test failed.

@tbg tbg merged commit bee419d into cockroachdb:master Aug 22, 2017
@knz
Copy link
Contributor

knz commented Aug 22, 2017

Please create a followup issue to address the problem durably.

  • Either the docker run thing should change the UID of the cockroach process (to eliminate the root cause)

  • Or the test should be run outside of Docker

@jordanlewis jordanlewis deleted the disable-mem-monitor-test branch November 7, 2017 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants