Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: fix error messages on the range page #17785

Merged
merged 1 commit into from
Aug 22, 2017

Conversation

BramGruneir
Copy link
Member

Fixes #17744.

Error page when the range ID is 0 or less:
screen shot 2017-08-21 at 12 45 50

Loading page when first going to the range report page:
screen shot 2017-08-21 at 12 45 23

Loading page when a new range id is entered:
screen shot 2017-08-21 at 12 44 52

Error page when the range is not found:
screen shot 2017-08-21 at 12 44 37

@BramGruneir BramGruneir requested a review from a team August 21, 2017 16:48
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@BramGruneir BramGruneir added this to the 1.1 milestone Aug 21, 2017
Copy link
Contributor

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐶

@BramGruneir BramGruneir force-pushed the reporting branch 2 times, most recently from c390703 to 344f931 Compare August 21, 2017 19:27
@BramGruneir BramGruneir merged commit d973d33 into cockroachdb:master Aug 22, 2017
@BramGruneir BramGruneir deleted the reporting branch August 22, 2017 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants