Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keys: fix pretty-printing of range local keys #17778

Conversation

petermattis
Copy link
Collaborator

Before:

/Local/Range/"\xb2"/RangeDescriptor

After:

/Local/Range/Table/42/RangeDescriptor

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2017

CLA assistant check
All committers have signed the CLA.

Before:

  /Local/Range/"\xb2"/RangeDescriptor

After:

  /Local/Range/Table/42/RangeDescriptor
@petermattis petermattis force-pushed the pmattis/pretty-print-range-local-key branch from 01d067f to 2b35e26 Compare August 21, 2017 14:08
@petermattis petermattis requested a review from tbg August 21, 2017 14:33
@petermattis petermattis merged commit a1440da into cockroachdb:master Aug 21, 2017
@petermattis petermattis deleted the pmattis/pretty-print-range-local-key branch August 21, 2017 15:01
@spencerkimball
Copy link
Member

Is Table confusing in this context? Why not /Local/Range/ID=42/RangeDescriptor? Maybe I'm missing something.

@petermattis
Copy link
Collaborator Author

The format is /Local/Range/[key]/RangeDescriptor where [key] is any other valid key. It usually will not be a simple table ID, but instead the boundary between 2 ranges of a table (i.e. /Table/42/1/-5000/"foo", or something like: /System/"" which is the end of meta2.

petermattis added a commit to petermattis/cockroach that referenced this pull request Aug 24, 2017
Follow on to cockroachdb#17778. We use bare range local keys (without a suffix)
during splits to lock an entire range of keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants