build: Run allocator acceptance tests with verbose logging #17736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
|
Yup, this works as intended, although the test passed. I'll merge once CI is green. |
Without these, the logs don't include any info to help debug failures, and after the cluster has shut down there's really nothing to go by.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these, the logs don't include any info to help debug failures,
and after the cluster has shut down there's really nothing to go by.
I'm still in the process of testing this out, so I won't merge it until I've verified it works and does what I want.
This will help confirm my hypotheses on #17685, assuming a run fails again soon, and will help with future debugging of these tests.