storage: restore range information in AdminScatterResponse #17409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
benesch
force-pushed
the
scatter-resp
branch
2 times, most recently
from
bce1354 to
59abcf4
Compare
|
Reviewed 2 of 2 files at r1. pkg/sql/split_at_test.go, line 225 at r1 (raw file):
don't forget to check Comments from Reviewable |
`ALTER TABLE... SCATTER` expects to receive a list of ranges that were scattered. This information was accidentally dropped in the new scatter implementation (dbd90cf, cockroachdb#16249). This commit restores the old behavior, and adds a test to boot. Fixes cockroachdb#17153.
|
Review status: 1 of 2 files reviewed at latest revision, 1 unresolved discussion. pkg/sql/split_at_test.go, line 225 at r1 (raw file): Previously, tamird (Tamir Duberstein) wrote…
Good call. Done. Comments from Reviewable |
|
Reviewed 1 of 1 files at r2. Comments from Reviewable |
benesch
added a commit
to benesch/cockroach
that referenced
this pull request
Aug 8, 2017
storage: restore range information in AdminScatterResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALTER TABLE... SCATTERexpects to receive a list of ranges that werescattered. This information was accidentally dropped in the new
scatter implementation (dbd90cf, #16249). This commit restores the old
behavior, and adds a test to boot.
Fixes #17153.