sql: change query ID type from string to Uint128 #17206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the query ID type that is commonly used from string to Uint128. This avoids the conversion to/from string in the common case, reserving such conversion for when queries are listed and cancelled. The Uint128 representation is smaller, faster to hash (for maps), faster to compare and doesn't require an allocation.
|
This change is |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the query ID type that is commonly used from string to
Uint128. This avoids the conversion to/from string in the common case,
reserving such conversion for when queries are listed and cancelled. The
Uint128 representation is smaller, faster to hash (for maps), faster to
compare and doesn't require an allocation.