Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/parser: Added current_schema keyword support. #16921

Merged
merged 1 commit into from
Jul 8, 2017

Conversation

CMajeri
Copy link

@CMajeri CMajeri commented Jul 7, 2017

current_schema can be used as an alias for the current_schema() builtin.
It is used by some applications like Keycloak.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2017

CLA assistant check
All committers have signed the CLA.

@jordanlewis
Copy link
Member

Thanks for the contribution! This looks correct to me, but it's missing tests. Please add a test to sql/parser/parse_test.go - there should already be a similar one for current_timestamp, for instance.


Reviewed 4 of 4 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@jordanlewis
Copy link
Member

Great - now could you please squash the two commits and rebase them instead of including merge commits? Then I think we'll be good to go.

@jordanlewis jordanlewis requested review from jordanlewis and knz July 7, 2017 15:59
current_schema can be used as an alias for the current_schema() builtin.
It is used by some applications like Keycloak.
@CMajeri
Copy link
Author

CMajeri commented Jul 7, 2017

Hi, I already squashed them didn't I? I can only see one commit in my PR.

@jordanlewis
Copy link
Member

Yes, it looks good now. Before it showed several commits, perhaps it was a GitHub ui blip.

@knz
Copy link
Contributor

knz commented Jul 7, 2017

:lgtm:


Reviewed 4 of 4 files at r1, 1 of 1 files at r2.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@jordanlewis jordanlewis merged commit 3824cc1 into cockroachdb:master Jul 8, 2017
@knz
Copy link
Contributor

knz commented Jul 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants