storage: Deflake TestSplitSnapshotRace_SnapshotWins #16893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
multiTestContext was not properly filling in the destination of its request, leading to a fallback search in Stores.Send which could send a request to a stale replica when combined with outdated information in the DistSender's cache. Specifically, a request to the post-split RHS was being sent to a pre-split replica, which did not have a quorum because the LHS stores were stopped, so it spun endlessly trying to get a lease. Fixes cockroachdb#16251
|
This change is |
I really don't like that fallback search in Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
|
Yeah, I've wanted to get rid of it for a long time too. But a lot of tests in the storage package rely on it. (This is issue #9014) Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
multiTestContext was not properly filling in the destination of its
request, leading to a fallback search in Stores.Send which could send
a request to a stale replica when combined with outdated information
in the DistSender's cache.
Specifically, a request to the post-split RHS was being sent to a
pre-split replica, which did not have a quorum because the LHS stores
were stopped, so it spun endlessly trying to get a lease.
Fixes #16251