Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage/engine: log RocksDB compaction stats #16880

Merged

Conversation

petermattis
Copy link
Collaborator

Periodically log RocksDB compaction stats which include details such as
write amplification per level.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@petermattis petermattis requested a review from tbg July 6, 2017 14:38
@petermattis
Copy link
Collaborator Author

For an example of what this output looks like, see https://github.com/facebook/rocksdb/wiki/RocksDB-Tuning-Guide#rocksdb-statistics.

@tbg
Copy link
Member

tbg commented Jul 6, 2017

:lgtm:


Reviewed 5 of 5 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


pkg/storage/engine/rocksdb.go, line 832 at r1 (raw file):

}

// GetCompactionStats returns the internal RocksDB compaction stats.

Since you're eating CI anyway, mind adding the link to RocksDB's explanation in the comment?


Comments from Reviewable

Periodically log RocksDB compaction stats which include details such as
write amplification per level.
@petermattis petermattis force-pushed the pmattis/rocksb-compaction-stats branch from de91a45 to f1a4152 Compare July 6, 2017 15:11
@petermattis
Copy link
Collaborator Author

Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


pkg/storage/engine/rocksdb.go, line 832 at r1 (raw file):

Previously, tschottdorf (Tobias Schottdorf) wrote…

Since you're eating CI anyway, mind adding the link to RocksDB's explanation in the comment?

Done.


Comments from Reviewable

@tbg
Copy link
Member

tbg commented Jul 6, 2017

Reviewed 1 of 1 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks pending.


Comments from Reviewable

@petermattis petermattis merged commit f3e9941 into cockroachdb:master Jul 6, 2017
@petermattis petermattis deleted the pmattis/rocksb-compaction-stats branch July 6, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants