ui: Palette Cleansing #16550
ui: Palette Cleansing #16550
Conversation
|
This change is |
|
Reviewed 19 of 19 files at r1. pkg/ui/styl/pages/debug.styl, line 34 at r1 (raw file):
why the repetition? Comments from Reviewable |
|
Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. pkg/ui/styl/pages/debug.styl, line 34 at r1 (raw file): Previously, tamird (Tamir Duberstein) wrote…
Yeah, this should have two different colors. Comments from Reviewable |
Cuts down our stylus color palette to a small fraction of the colors defined previously; early in UI development we were rampantly defining colors with little thought given to any sort of common palette, and there was a lot of cleanup debt remaining. As of this commit, we are using only 21 colors in the UI, and each one of them has a consistent semantic meaning. Special thanks to @kuanluo for sitting with me for two hours while we tediously went through this.
mrtracy
force-pushed
the
mtracy/ui-palette-cleanse
branch
from
31204f4 to
9c4fda6
Compare
|
Review status: 17 of 19 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful. pkg/ui/styl/pages/debug.styl, line 34 at r1 (raw file): Previously, BramGruneir (Bram Gruneir) wrote…
Fixed, using white for now; these should be getting a design pass soon anyway. Comments from Reviewable |
Cuts down our stylus color palette to a small fraction of the colors
defined previously; early in UI development we were rampantly defining
colors with little thought given to any sort of common palette, and
there was a lot of cleanup debt remaining. As of this commit, we are
using only 21 colors in the UI, and each one of them has a consistent
semantic meaning.
Special thanks to @kuanluo for sitting with me for two hours while we
tediously went through this.