kubernetes: Use explicit image tag #15878
Merged
+1
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
It might be slightly annoying to keep up-to-date as releases happen, but this is widely considered a best practice to avoid accidentally ending up with different versions in different pods.
|
LGTM. Can you update our relevant release checklists to add this step prior to merging? |
tbg
approved these changes
May 11, 2017
|
Good call, I updated the release process instructions: https://github.com/cockroachdb/cockroach/wiki/Release-process |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be slightly annoying to keep up-to-date as releases happen,
but this is widely considered a best practice to avoid accidentally
ending up with different versions in different pods.
I'll also be updating our upstream configs in the Kubernetes and Helm repos.