Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: construct proper index spans in the presence of tuples with NULL #15612

Merged
merged 1 commit into from
May 3, 2017
Merged

sql: construct proper index spans in the presence of tuples with NULL #15612

merged 1 commit into from
May 3, 2017

Conversation

eisenstatdavid
Copy link

This is a temporary solution to #12022. The permanent fix should wait
for a SQL intermediate representation and the attendant rewrite of the
index selection code.

@eisenstatdavid eisenstatdavid requested a review from knz May 2, 2017 19:31
@knz knz added the in progress label May 2, 2017
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz
Copy link
Contributor

knz commented May 3, 2017

LGTM

  • please report the current TC error to the distsql team
  • out of curiosity, how will an IR help with a permanent fix?

@eisenstatdavid
Copy link
Author

out of curiosity, how will an IR help with a permanent fix?

The IR seemed like the most plausible trigger for redoing index selection.

@knz
Copy link
Contributor

knz commented May 3, 2017

Heh I wouldn't be so optimistic, but oh well. :)

This is a temporary solution to #12022. The permanent fix should wait
for a SQL intermediate representation and the attendant rewrite of the
index selection code.
@eisenstatdavid eisenstatdavid merged commit 1968f08 into cockroachdb:master May 3, 2017
@knz knz removed the in progress label May 3, 2017
@eisenstatdavid eisenstatdavid deleted the span-tuple-with-null branch May 3, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants