sqlccl: log scatter errors in RESTORE #15047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a useful debugging aid when trying to figure out why scatter didn't seem to be working.
|
This change is |
|
Though (unrelated to this change) as with any logged-then-ignored error, I worry about it regressing unnoticed -- I wonder if could e.g. hook log.Warning in tests to t.Fatal or something. Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
|
failing the test when this happened would make it flaky. I made an issue to fix the best-effort nature of scatter, which means this could be made a failing error: #15049 Review status: 0 of 1 files reviewed at latest revision, all discussions resolved, some commit checks pending. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a useful debugging aid when trying to figure out why scatter
didn't seem to be working.